Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec

From	Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec
Date	2016-10-30 21:30 +0100
Message-ID	<sy4TT-ZR-1@gated-at.bofh.it> (permalink)
References	<sxcgN-6SN-3@gated-at.bofh.it> <sxcgO-6SN-25@gated-at.bofh.it> <sy3bs-8hY-11@gated-at.bofh.it> <sy4Ax-PU-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 30 October 2016 20:04:09 GMT+00:00, Brian Masney <masneyb@onstation.org> wrote:
>On Sun, Oct 30, 2016 at 06:37:40PM +0000, Jonathan Cameron wrote:
>> On 28/10/16 11:00, Brian Masney wrote:
>> > The illuminance0_calibscale sysfs attribute is not currently
>created by
>> > the IIO core. This patch adds the appropriate mask to
>iio_chan_spec,
>> > along with the appropriate data handling in the read_raw() and
>> > write_raw() functions, so that the sysfs attribute is created by
>the IIO
>> > core. With this change, this sysfs entry will have its prefix
>changed
>> > from illuminance0_ to in_illuminance_.
>> > 
>> > Signed-off-by: Brian Masney <masneyb@onstation.org>
>> Hmm. Could probably have computed the mean on the fly but fine as is.
>
>Hi Jonathan,
>   Thanks for your feedback. I'll have another patch set ready for you
>by next weekend with my next round of cleanups to that driver. I'll
>change this so that it calculates the mean on the fly unless I hear
>otherwise from you.

I don't worry about the mean change. Not worth changing to my mind.

J
>
>Brian
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec Brian Masney <masneyb@onstation.org> - 2016-10-28 12:10 +0200
  Re: [PATCH 07/10] staging: iio: tsl2583: convert  illuminance0_calibscale sysfs attr to use iio_chan_spec Jonathan Cameron <jic23@kernel.org> - 2016-10-30 19:40 +0100
    Re: [PATCH 07/10] staging: iio: tsl2583: convert  illuminance0_calibscale sysfs attr to use iio_chan_spec Brian Masney <masneyb@onstation.org> - 2016-10-30 21:10 +0100
      Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2016-10-30 21:30 +0100

csiph-web