Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512180

Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec

Show all headers | View raw

On Sun, Oct 30, 2016 at 06:37:40PM +0000, Jonathan Cameron wrote:
> On 28/10/16 11:00, Brian Masney wrote:
> > The illuminance0_calibscale sysfs attribute is not currently created by
> > the IIO core. This patch adds the appropriate mask to iio_chan_spec,
> > along with the appropriate data handling in the read_raw() and
> > write_raw() functions, so that the sysfs attribute is created by the IIO
> > core. With this change, this sysfs entry will have its prefix changed
> > from illuminance0_ to in_illuminance_.
> > 
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> Hmm. Could probably have computed the mean on the fly but fine as is.

Hi Jonathan,
   Thanks for your feedback. I'll have another patch set ready for you
by next weekend with my next round of cleanups to that driver. I'll
change this so that it calculates the mean on the fly unless I hear
otherwise from you.

Brian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec Brian Masney <masneyb@onstation.org> - 2016-10-28 12:10 +0200
  Re: [PATCH 07/10] staging: iio: tsl2583: convert  illuminance0_calibscale sysfs attr to use iio_chan_spec Jonathan Cameron <jic23@kernel.org> - 2016-10-30 19:40 +0100
    Re: [PATCH 07/10] staging: iio: tsl2583: convert  illuminance0_calibscale sysfs attr to use iio_chan_spec Brian Masney <masneyb@onstation.org> - 2016-10-30 21:10 +0100
      Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2016-10-30 21:30 +0100

csiph-web