[PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!enother.net!enother.net!enother.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate
Date	Fri, 28 Oct 2016 12:40:02 +0200
Message-ID	<sxcJP-77Y-9@gated-at.bofh.it> (permalink)
Authentication-Results	ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com
X-Mailer	git-send-email 2.1.4
MIME-Version	1.0
Content-Type	text/plain
X-Proofpoint-Spam-Details	rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610280186
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-kernel@vger.kernel.org>, <patches@opensource.wolfsonmicro.com>
X-Original-Date	Fri, 28 Oct 2016 11:32:53 +0100
X-Original-Message-ID	<1477650774-22239-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1511052

Show key headers only | View raw

No need to use irq_create_mapping (although there is no issue with
doing so) when we are only looking up an existing mapping. Just to
streamline things a little and make the code a little more clear
change some calls from irq_create_mapping to irq_find_mapping.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/mfd/arizona-irq.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c
index 5e18d3c..2e01975 100644
--- a/drivers/mfd/arizona-irq.c
+++ b/drivers/mfd/arizona-irq.c
@@ -398,10 +398,10 @@ int arizona_irq_init(struct arizona *arizona)
 err_boot_done:
 	free_irq(arizona->irq, arizona);
 err_main_irq:
-	regmap_del_irq_chip(irq_create_mapping(arizona->virq, 1),
+	regmap_del_irq_chip(irq_find_mapping(arizona->virq, 1),
 			    arizona->irq_chip);
 err_aod:
-	regmap_del_irq_chip(irq_create_mapping(arizona->virq, 0),
+	regmap_del_irq_chip(irq_find_mapping(arizona->virq, 0),
 			    arizona->aod_irq_chip);
 err:
 	return ret;
@@ -413,9 +413,9 @@ int arizona_irq_exit(struct arizona *arizona)
 		free_irq(arizona_map_irq(arizona, ARIZONA_IRQ_CTRLIF_ERR),
 			 arizona);
 	free_irq(arizona_map_irq(arizona, ARIZONA_IRQ_BOOT_DONE), arizona);
-	regmap_del_irq_chip(irq_create_mapping(arizona->virq, 1),
+	regmap_del_irq_chip(irq_find_mapping(arizona->virq, 1),
 			    arizona->irq_chip);
-	regmap_del_irq_chip(irq_create_mapping(arizona->virq, 0),
+	regmap_del_irq_chip(irq_find_mapping(arizona->virq, 0),
 			    arizona->aod_irq_chip);
 	free_irq(arizona->irq, arizona);
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-28 12:40 +0200
  [PATCH 2/2] mfd: arizona: Correctly clean up after IRQs Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-28 12:40 +0200
    Re: [PATCH 2/2] mfd: arizona: Correctly clean up after IRQs Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-11-11 15:00 +0100
  Re: [PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate Lee Jones <lee.jones@linaro.org> - 2016-11-10 14:30 +0100

csiph-web