Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511052
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate |
| Date | 2016-10-28 12:40 +0200 |
| Message-ID | <sxcJP-77Y-9@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
No need to use irq_create_mapping (although there is no issue with doing so) when we are only looking up an existing mapping. Just to streamline things a little and make the code a little more clear change some calls from irq_create_mapping to irq_find_mapping. Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- drivers/mfd/arizona-irq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c index 5e18d3c..2e01975 100644 --- a/drivers/mfd/arizona-irq.c +++ b/drivers/mfd/arizona-irq.c @@ -398,10 +398,10 @@ int arizona_irq_init(struct arizona *arizona) err_boot_done: free_irq(arizona->irq, arizona); err_main_irq: - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 1), + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 1), arizona->irq_chip); err_aod: - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 0), + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 0), arizona->aod_irq_chip); err: return ret; @@ -413,9 +413,9 @@ int arizona_irq_exit(struct arizona *arizona) free_irq(arizona_map_irq(arizona, ARIZONA_IRQ_CTRLIF_ERR), arizona); free_irq(arizona_map_irq(arizona, ARIZONA_IRQ_BOOT_DONE), arizona); - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 1), + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 1), arizona->irq_chip); - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 0), + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 0), arizona->aod_irq_chip); free_irq(arizona->irq, arizona); -- 2.1.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-28 12:40 +0200
[PATCH 2/2] mfd: arizona: Correctly clean up after IRQs Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-28 12:40 +0200
Re: [PATCH 2/2] mfd: arizona: Correctly clean up after IRQs Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-11-11 15:00 +0100
Re: [PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate Lee Jones <lee.jones@linaro.org> - 2016-11-10 14:30 +0100
csiph-web