Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1510922
| From | Vincent Stehlé <vincent.stehle@laposte.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument |
| Date | 2016-10-28 10:00 +0200 |
| Message-ID | <sxaf0-5mE-37@gated-at.bofh.it> (permalink) |
| References | <sf7pg-6h3-19@gated-at.bofh.it> <swZtg-6Gr-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Oct 27, 2016 at 10:23:24PM +0200, Vincent Stehlé wrote: > video_device_release() takes a pointer to struct video_device as argument. > Fix two call sites where the address of the pointer is passed instead. Sorry, I messed up: please ignore that "fix". The 0day robot made me realize this is indeed not a proper fix. The issue remains, though: we cannot call video_device_release() on the vdev structure member, as this will in turn call kfree(). Most probably, vdev needs to be dynamically allocated, or the call to video_device_release() dropped completely. Sorry for the bad patch. Best regards, Vincent.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH next 1/2] media: mtk-mdp: fix video_device_release argument Vincent Stehlé <vincent.stehle@laposte.net> - 2016-10-27 22:50 +0200
Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument Vincent Stehlé <vincent.stehle@laposte.net> - 2016-10-28 10:00 +0200
Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument Hans Verkuil <hverkuil@xs4all.nl> - 2016-11-03 13:50 +0100
Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument Minghsiu Tsai <minghsiu.tsai@mediatek.com> - 2016-11-07 13:50 +0100
csiph-web