Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument

From	Minghsiu Tsai <minghsiu.tsai@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument
Date	2016-11-07 13:50 +0100
Message-ID	<sARx7-3aL-13@gated-at.bofh.it> (permalink)
References	<sf7pg-6h3-19@gated-at.bofh.it> <swZtg-6Gr-23@gated-at.bofh.it> <sxaf0-5mE-37@gated-at.bofh.it> <szpCV-3Ud-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-11-03 at 13:47 +0100, Hans Verkuil wrote:
> Hi Vincent,
> 
> On 28/10/16 09:52, Vincent Stehlé wrote:
> > On Thu, Oct 27, 2016 at 10:23:24PM +0200, Vincent Stehlé wrote:
> >> video_device_release() takes a pointer to struct video_device as argument.
> >> Fix two call sites where the address of the pointer is passed instead.
> >
> > Sorry, I messed up: please ignore that "fix". The 0day robot made me
> > realize this is indeed not a proper fix.
> >
> > The issue remains, though: we cannot call video_device_release() on the
> > vdev structure member, as this will in turn call kfree(). Most probably,
> > vdev needs to be dynamically allocated, or the call to
> > video_device_release() dropped completely.
> 
> I prefer that vdev is dynamically allocated. There are known problems with
> embedded video_device structs, so allocating it is preferred.
> 
> Minghsiu, can you do that?
> 

Hi Hans,

I just send the patch for this.
https://patchwork.kernel.org/patch/9415007/


> Regards,
> 
> 	Hans
> 
> >
> > Sorry for the bad patch.
> >
> > Best regards,
> >
> > Vincent.
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH next 1/2] media: mtk-mdp: fix video_device_release argument Vincent Stehlé <vincent.stehle@laposte.net> - 2016-10-27 22:50 +0200
  Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release  argument Vincent Stehlé <vincent.stehle@laposte.net> - 2016-10-28 10:00 +0200
    Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release  argument Hans Verkuil <hverkuil@xs4all.nl> - 2016-11-03 13:50 +0100
      Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release  argument Minghsiu Tsai <minghsiu.tsai@mediatek.com> - 2016-11-07 13:50 +0100

csiph-web