Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511889
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) |
| Date | 2016-10-29 22:10 +0200 |
| Message-ID | <sxI6Z-2Kc-9@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <sxDK1-7WB-17@gated-at.bofh.it> <sxFVv-1aY-1@gated-at.bofh.it> <sxH1f-1QO-7@gated-at.bofh.it> <sxHaV-29g-11@gated-at.bofh.it> <sxHkB-2cH-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Oct 29, 2016 at 12:17 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> AFAICS, the possibility of dropping the last reference to struct file
> before ->write_iter() has returned is fundamentally broken. I might be
> missing something subtle here, but...
Ok, let's add a get_file(); fput(); around that whole iter call sequence.
And that's a separate issue from "we should hold the fs freezer lock
around the whole operation". So I think we need both.
Does that make everybody happy?
Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-29 09:50 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 14:30 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-29 17:30 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 18:20 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 18:40 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-30 07:40 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-29 19:50 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 21:00 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-29 21:10 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 21:20 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-29 22:10 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Jan Kara <jack@suse.cz> - 2016-10-30 10:50 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Jan Kara <jack@suse.cz> - 2016-10-30 12:00 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-30 17:00 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-30 07:40 +0100
csiph-web