Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511641
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) |
| Date | 2016-10-29 14:30 +0200 |
| Message-ID | <sxAVP-6bh-9@gated-at.bofh.it> (permalink) |
| References | <sxwyR-3dk-3@gated-at.bofh.it> <sxwyR-3dk-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Oct 29, 2016 at 09:44:29AM +0200, Christoph Hellwig wrote:
> - if (rw == WRITE)
> + if (rw == WRITE) {
> file_start_write(file);
> + req->ki_flags |= IOCB_WRITE;
> + }
> + if (rw == WRITE) {
> + /*
> + * We release freeze protection in aio_complete(). Fool
> + * lockdep by telling it the lock got released so that
> + * it doesn't complain about held lock when we return
> + * to userspace.
> + */
> + __sb_writers_release(file_inode(file)->i_sb,
> + SB_FREEZE_WRITE);
> + }
How about taking this chunk (i.e. telling lockdep that we are not holding this
thing) past the iter_op() call, where file_end_write() used to be?
As it is, you risk hiding the lock dependencies the current mainline would've
caught. Other than that I see no problems with the patch...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-29 09:50 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 14:30 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-29 17:30 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 18:20 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 18:40 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-30 07:40 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-29 19:50 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 21:00 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-29 21:10 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-29 21:20 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-29 22:10 +0200
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Jan Kara <jack@suse.cz> - 2016-10-30 10:50 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Jan Kara <jack@suse.cz> - 2016-10-30 12:00 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-30 17:00 +0100
Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig <hch@lst.de> - 2016-10-30 07:40 +0100
csiph-web