Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1508899
| From | Wanpeng Li <kernellwp@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash |
| Date | 2016-10-26 10:10 +0200 |
| Message-ID | <swrrA-U4-23@gated-at.bofh.it> (permalink) |
| References | <swo0F-72Y-7@gated-at.bofh.it> <swqYy-t9-17@gated-at.bofh.it> <swrhT-A6-3@gated-at.bofh.it> <swrhT-A6-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2016-10-26 15:56 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>: > > > On 26/10/2016 09:55, Wanpeng Li wrote: >>>> >> -static void kvm_guest_apic_eoi_write(u32 reg, u32 val) >>>> >> +static void kvm_guest_apic_eoi_write_notrace(u32 reg, u32 val) >>> > >>> > Huh, this is not notrace?!? >> Sorry, maybe I misunderstand you. >> >> ack_APIC_irq() >> -> apic_eoi() >> -> apic->eoi_write() >> -> kvm_guest_apic_eoi_write() >> -> apic->native_eoi_write() >> -> native_apic_msr_eoi_write() >> -> wrmsr_notrace() >> -> native_write_msr_notrace() >> -> native_apic_mem_write() >> >> The call path is notrace. Where I miss? > > kvm_guest_apic_eoi_write should be marked as notrace, shouldn't it? I see. notrace static void kvm_guest_apic_eoi_write_notrace(u32 reg, u32 val) and notrace static void kvm_guest_apic_eoi_write(u32 reg, u32 val), which one you prefer? Regards, Wanpeng Li
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 06:30 +0200
Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 09:40 +0200
Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 10:00 +0200
Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 10:10 +0200
Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 13:30 +0200
Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 13:30 +0200
Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 10:00 +0200
csiph-web