Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508890

Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash

Show all headers | View raw

On 26/10/2016 09:55, Wanpeng Li wrote:
>>> >> -static void kvm_guest_apic_eoi_write(u32 reg, u32 val)
>>> >> +static void kvm_guest_apic_eoi_write_notrace(u32 reg, u32 val)
>> >
>> > Huh, this is not notrace?!?
> Sorry, maybe I misunderstand you.
> 
> ack_APIC_irq()
>   -> apic_eoi()
>     -> apic->eoi_write()
>       -> kvm_guest_apic_eoi_write()
>         -> apic->native_eoi_write()
>           -> native_apic_msr_eoi_write()
>             -> wrmsr_notrace()
>               -> native_write_msr_notrace()
>           -> native_apic_mem_write()
> 
> The call path is notrace. Where I miss?

kvm_guest_apic_eoi_write should be marked as notrace, shouldn't it?

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] x86/msr: Add write msr notrace to avoid the debug codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 06:30 +0200
  Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug  codes splash Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 09:40 +0200
    Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug  codes splash Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 10:00 +0200
      Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug  codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 10:10 +0200
        Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug  codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 13:30 +0200
        Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug  codes splash Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 13:30 +0200
    Re: [PATCH v4] x86/msr: Add write msr notrace to avoid the debug  codes splash Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 10:00 +0200

csiph-web