Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508657

Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

Show all headers | View raw

Hi Arnaldo,

On Tue, Oct 25, 2016 at 03:07:46PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim escreveu:
> > Applying cpu color always doesn't help readability IMHO.  Instead it
> > might be better to applying the color when there's an activity on those
> > CPUs.
> 
> thanks, applied the three patches.

Thanks, but unfortunately the patch 3/3 has a bug.  Could you please
fold the fix below into the patch?

Thanks,
Namhyung


diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index f0ab715b4923..a8e58d495a66 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1218,7 +1218,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
 	      (double)work_list->total_runtime / NSEC_PER_MSEC,
 		 work_list->nb_atoms, (double)avg / NSEC_PER_MSEC,
 		 (double)work_list->max_lat / NSEC_PER_MSEC,
-		 timestamp_in_usec(buf, sizeof(buf), work_list->max_lat));
+		 timestamp_in_usec(buf, sizeof(buf), work_list->max_lat_at));
 }
 
 static int pid_cmp(struct work_atoms *l, struct work_atoms *r)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] perf sched map: Apply cpu color when there's an activity Namhyung Kim <namhyung@kernel.org> - 2016-10-24 04:10 +0200
  Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an  activity Jiri Olsa <jolsa@redhat.com> - 2016-10-24 18:50 +0200
  Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an  activity Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-25 20:10 +0200
    Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an  activity Namhyung Kim <namhyung@kernel.org> - 2016-10-25 23:30 +0200

csiph-web