[PATCH 1/3] perf sched map: Apply cpu color when there's an activity

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] perf sched map: Apply cpu color when there's an activity
Date	2016-10-24 04:10 +0200
Message-ID	<svCS6-18W-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Applying cpu color always doesn't help readability IMHO.  Instead it
might be better to applying the color when there's an activity on those
CPUs.

Cc: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index f5503ca22e1c..78006e991d91 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1479,7 +1479,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
 			cpu_color = COLOR_CPUS;
 
 		if (cpu != this_cpu)
-			color_fprintf(stdout, cpu_color, " ");
+			color_fprintf(stdout, color, " ");
 		else
 			color_fprintf(stdout, cpu_color, "*");
 
-- 
2.10.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] perf sched map: Apply cpu color when there's an activity Namhyung Kim <namhyung@kernel.org> - 2016-10-24 04:10 +0200
  Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an  activity Jiri Olsa <jolsa@redhat.com> - 2016-10-24 18:50 +0200
  Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an  activity Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-25 20:10 +0200
    Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an  activity Namhyung Kim <namhyung@kernel.org> - 2016-10-25 23:30 +0200

csiph-web