Re: [RFC/PATCH 2/2] perf sched: Make common options cascading

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC/PATCH 2/2] perf sched: Make common options cascading
Date	2016-10-25 23:30 +0200
Message-ID	<swhsd-2CS-1@gated-at.bofh.it> (permalink)
References	<svDO9-1Rh-19@gated-at.bofh.it> <svDO9-1Rh-17@gated-at.bofh.it> <svQV4-26N-31@gated-at.bofh.it> <swdHX-cg-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 25, 2016 at 02:21:32PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 24, 2016 at 07:03:32PM +0200, Jiri Olsa escreveu:
> > On Mon, Oct 24, 2016 at 12:00:03PM +0900, Namhyung Kim wrote:
> > > The -i and -v options can be used in subcommands so enable cascading the
> > > sched_options.  This fixes the following inconvenience in 'perf sched':
> > > 
> > >   $ perf sched -i perf.data.sched  map
> > >   ... (it works well) ...
> > > 
> > >   $ perf sched map  -i perf.data.sched
> > >     Error: unknown switch `i'
> > > 
> > >    Usage: perf sched map [<options>]
> > > 
> > >           --color-cpus <cpus>
> > >                             highlight given CPUs in map
> > >           --color-pids <pids>
> > >                             highlight given pids in map
> > >           --compact         map output in compact mode
> > >           --cpus <cpus>     display given CPUs in map
> > > 
> > > With this patch, the second command line works with the perf.data.sched
> > > data file.
> > > 
> > > Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > 
> > good idea, I'll use it in c2c ;-)
> > 
> > for both:
> > 
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> Applied, I guess 'perf kvm' would be another user, to make it sane wrt
> file_name, -i and -o being available for 'perf kvm record', etc.

Yep, I think we have few more.  I'll send the patch when I can find a
time (FYI I'm travelling now).

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC/PATCH 1/2] tools lib subcmd: Suppport cascading options Namhyung Kim <namhyung@kernel.org> - 2016-10-24 05:10 +0200
  [RFC/PATCH 2/2] perf sched: Make common options cascading Namhyung Kim <namhyung@kernel.org> - 2016-10-24 05:10 +0200
    Re: [RFC/PATCH 2/2] perf sched: Make common options cascading Jiri Olsa <jolsa@redhat.com> - 2016-10-24 19:10 +0200
      Re: [RFC/PATCH 2/2] perf sched: Make common options cascading Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-25 19:30 +0200
        Re: [RFC/PATCH 2/2] perf sched: Make common options cascading Namhyung Kim <namhyung@kernel.org> - 2016-10-25 23:30 +0200

csiph-web