Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508499

Re: [RFC/PATCH 2/2] perf sched: Make common options cascading

Show all headers | View raw

Em Mon, Oct 24, 2016 at 07:03:32PM +0200, Jiri Olsa escreveu:
> On Mon, Oct 24, 2016 at 12:00:03PM +0900, Namhyung Kim wrote:
> > The -i and -v options can be used in subcommands so enable cascading the
> > sched_options.  This fixes the following inconvenience in 'perf sched':
> > 
> >   $ perf sched -i perf.data.sched  map
> >   ... (it works well) ...
> > 
> >   $ perf sched map  -i perf.data.sched
> >     Error: unknown switch `i'
> > 
> >    Usage: perf sched map [<options>]
> > 
> >           --color-cpus <cpus>
> >                             highlight given CPUs in map
> >           --color-pids <pids>
> >                             highlight given pids in map
> >           --compact         map output in compact mode
> >           --cpus <cpus>     display given CPUs in map
> > 
> > With this patch, the second command line works with the perf.data.sched
> > data file.
> > 
> > Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> good idea, I'll use it in c2c ;-)
> 
> for both:
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Applied, I guess 'perf kvm' would be another user, to make it sane wrt
file_name, -i and -o being available for 'perf kvm record', etc.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC/PATCH 1/2] tools lib subcmd: Suppport cascading options Namhyung Kim <namhyung@kernel.org> - 2016-10-24 05:10 +0200
  [RFC/PATCH 2/2] perf sched: Make common options cascading Namhyung Kim <namhyung@kernel.org> - 2016-10-24 05:10 +0200
    Re: [RFC/PATCH 2/2] perf sched: Make common options cascading Jiri Olsa <jolsa@redhat.com> - 2016-10-24 19:10 +0200
      Re: [RFC/PATCH 2/2] perf sched: Make common options cascading Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-25 19:30 +0200
        Re: [RFC/PATCH 2/2] perf sched: Make common options cascading Namhyung Kim <namhyung@kernel.org> - 2016-10-25 23:30 +0200

csiph-web