Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1508550
| From | Solomon Peachy <pizza@shaftnet.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] cw1200: fix bogus maybe-uninitialized warning |
| Date | 2016-10-25 20:40 +0200 |
| Message-ID | <sweNI-Sp-19@gated-at.bofh.it> (permalink) |
| References | <svPFE-17R-25@gated-at.bofh.it> <sw9XI-6bh-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Oct 25, 2016 at 01:24:55PM +0000, David Laight wrote:
> > - if (count > 1) {
> > - /* We already released one buffer, now for the rest */
> > - ret = wsm_release_tx_buffer(priv, count - 1);
> > - if (ret < 0)
> > - return ret;
> > - else if (ret > 0)
> > - cw1200_bh_wakeup(priv);
> > - }
> > + /* We already released one buffer, now for the rest */
> > + ret = wsm_release_tx_buffer(priv, count - 1);
> > + if (ret < 0)
> > + return ret;
> > +
> > + if (ret > 0)
> > + cw1200_bh_wakeup(priv);
>
> That doesn't look equivalent to me (when count == 1).
I concur, this patch should not be applied in its current form.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] cw1200: fix bogus maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-10-24 17:50 +0200
RE: [PATCH] cw1200: fix bogus maybe-uninitialized warning David Laight <David.Laight@ACULAB.COM> - 2016-10-25 15:30 +0200
Re: [PATCH] cw1200: fix bogus maybe-uninitialized warning Solomon Peachy <pizza@shaftnet.org> - 2016-10-25 20:40 +0200
Re: [PATCH] cw1200: fix bogus maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-10-25 22:30 +0200
csiph-web