Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1510555

Re: [PATCH] EDAC: expose per-dimm error counts in sysfs

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Mauro Carvalho Chehab <mchehab@s-opensource.com>
Newsgroups linux.kernel
Subject Re: [PATCH] EDAC: expose per-dimm error counts in sysfs
Date Thu, 27 Oct 2016 20:20:01 +0200
Message-ID <swXrr-5ri-1@gated-at.bofh.it> (permalink)
References <swjkl-3Pu-1@gated-at.bofh.it> <swXhM-5la-25@gated-at.bofh.it>
Organization Samsung
X-Mailer Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 49
X-Original-Cc Aaron Miller <aaronmiller@fb.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Thu, 27 Oct 2016 16:18:57 -0200
X-Original-Message-ID <20161027161857.0c2a534a@vento.lan>
X-Original-References <20161025232551.3270769-1-aaronmiller@fb.com> <20161027180716.a5z6w2g5arco564h@pd.tnic>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1510555

Show key headers only | View raw


Em Thu, 27 Oct 2016 20:07:16 +0200
Borislav Petkov <bp@alien8.de> escreveu:

> On Tue, Oct 25, 2016 at 04:25:51PM -0700, Aaron Miller wrote:
> 
> <--- This patch needs a commit message.
> 
> Especially as to *why* we need this.

Also, if you're changing the sysfs ABI, you need to update the EDAC
documentation accordingly.

> 
> > Signed-off-by: Aaron Miller <aaronmiller@fb.com>
> > ---
> >  drivers/edac/edac_mc_sysfs.c | 38 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)  
> 
> Regardless, something's still not right yet:
> 
> $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject_channel
> $ echo 2 > /sys/kernel/debug/edac/mc0/fake_inject_slot
> $ echo 3 > /sys/kernel/debug/edac/mc0/fake_inject_count
>        ^
> 
> $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject
> 
> $ grep . /sys/devices/system/edac/mc/mc0/*count
> /sys/devices/system/edac/mc/mc0/ce_count:3
> 					 ^
> 
> /sys/devices/system/edac/mc/mc0/ce_noinfo_count:0
> /sys/devices/system/edac/mc/mc0/ue_count:0
> /sys/devices/system/edac/mc/mc0/ue_noinfo_count:0
> 
> $ grep -r . /sys/devices/system/edac/mc/mc0/dimm*/* 2>/dev/null | grep ce_count
> /sys/devices/system/edac/mc/mc0/dimm0/dimm_ce_count:0
> /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count:0
> /sys/devices/system/edac/mc/mc0/dimm6/dimm_ce_count:0
> /sys/devices/system/edac/mc/mc0/dimm9/dimm_ce_count:0
> 						    ^
> 
> There should be 3 somewhere in the DIMM counters...
> 



Thanks,
Mauro

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Borislav Petkov <bp@alien8.de> - 2016-10-27 20:10 +0200
  Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-27 20:20 +0200
  Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Aaron Miller <aaronmiller@fb.com> - 2016-10-27 23:30 +0200
    Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Aaron Miller <aaronmiller@fb.com> - 2016-10-28 12:00 +0200

csiph-web