Re: [PATCH] EDAC: expose per-dimm error counts in sysfs

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] EDAC: expose per-dimm error counts in sysfs
Date	2016-10-27 20:10 +0200
Message-ID	<swXhM-5la-25@gated-at.bofh.it> (permalink)
References	<swjkl-3Pu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 25, 2016 at 04:25:51PM -0700, Aaron Miller wrote:

<--- This patch needs a commit message.

Especially as to *why* we need this.

> Signed-off-by: Aaron Miller <aaronmiller@fb.com>
> ---
>  drivers/edac/edac_mc_sysfs.c | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)

Regardless, something's still not right yet:

$ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject_channel
$ echo 2 > /sys/kernel/debug/edac/mc0/fake_inject_slot
$ echo 3 > /sys/kernel/debug/edac/mc0/fake_inject_count
       ^

$ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject

$ grep . /sys/devices/system/edac/mc/mc0/*count
/sys/devices/system/edac/mc/mc0/ce_count:3
					 ^

/sys/devices/system/edac/mc/mc0/ce_noinfo_count:0
/sys/devices/system/edac/mc/mc0/ue_count:0
/sys/devices/system/edac/mc/mc0/ue_noinfo_count:0

$ grep -r . /sys/devices/system/edac/mc/mc0/dimm*/* 2>/dev/null | grep ce_count
/sys/devices/system/edac/mc/mc0/dimm0/dimm_ce_count:0
/sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count:0
/sys/devices/system/edac/mc/mc0/dimm6/dimm_ce_count:0
/sys/devices/system/edac/mc/mc0/dimm9/dimm_ce_count:0
						    ^

There should be 3 somewhere in the DIMM counters...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Borislav Petkov <bp@alien8.de> - 2016-10-27 20:10 +0200
  Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-27 20:20 +0200
  Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Aaron Miller <aaronmiller@fb.com> - 2016-10-27 23:30 +0200
    Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Aaron Miller <aaronmiller@fb.com> - 2016-10-28 12:00 +0200

csiph-web