Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1510430
| From | David Lechner <david@lechnology.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node |
| Date | 2016-10-27 18:00 +0200 |
| Message-ID | <swVfY-3Pm-39@gated-at.bofh.it> (permalink) |
| References | <swmLf-6hJ-1@gated-at.bofh.it> <swmLf-6hJ-5@gated-at.bofh.it> <swtD3-2ly-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/26/2016 05:26 AM, Sekhar Nori wrote:
> On Wednesday 26 October 2016 08:36 AM, David Lechner wrote:
>> Add a node for the new usb phy driver.
>
> changed this to:
>
> Add a node for usb phy device. This device
> controls both the USB 1.1 and USB 2.0 PHYs.
>
> mainly because the node is for the device, not the driver.
>
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>
> Applied to v4.10/dt
>
> Thanks,
> Sekhar
>
I found a better way to represent this device as a child of the syscon
node. How should we handle the change? Should I submit a new patch that
applies on top of this one or will you drop this patch and I should send
a new one to take it's place?
Assuming that you agree that this is better:
cfgchip: cfgchip@1417c {
compatible = "ti,da830-cfgchip", "syscon", "simple-mfd";
reg = <0x1417c 0x14>;
usb_phy: usb-phy {
compatible = "ti,da830-usb-phy";
#phy-cells = <1>;
status = "disabled";
};
};
Since the phy consists entirely as registers in the syscon device, we
should make it a child of the syscon device instead of a child of the
soc node.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 0/5] da8xx USB PHY platform devices and clocks David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
[PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node Sekhar Nori <nsekhar@ti.com> - 2016-10-26 12:30 +0200
Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node David Lechner <david@lechnology.com> - 2016-10-26 18:10 +0200
Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node Sekhar Nori <nsekhar@ti.com> - 2016-10-28 10:30 +0200
Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node Kevin Hilman <khilman@baylibre.com> - 2016-10-28 19:10 +0200
Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node David Lechner <david@lechnology.com> - 2016-10-28 19:30 +0200
Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node Kevin Hilman <khilman@baylibre.com> - 2016-10-28 23:00 +0200
[PATCH v6 5/5] ARM: DTS: da850: Add usb phy node David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
Re: [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node Sekhar Nori <nsekhar@ti.com> - 2016-10-26 12:30 +0200
Re: [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node David Lechner <david@lechnology.com> - 2016-10-27 18:00 +0200
[PATCH v6 3/5] ARM: davinci: da8xx: Add USB PHY platform declaration David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
[PATCH v6 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
Re: [PATCH v6 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. Sekhar Nori <nsekhar@ti.com> - 2016-10-26 12:00 +0200
[PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-10-26 10:10 +0200
Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-10-26 18:40 +0200
Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-10-26 19:20 +0200
Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-10-26 11:30 +0200
csiph-web