Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508906

Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks

Show all headers | View raw

On Wednesday 26 October 2016 08:36 AM, David Lechner wrote:
> Up to this point, the USB phy clock configuration was handled manually in
> the board files and in the usb drivers. This adds proper clocks so that
> the usb drivers can use clk_get and clk_enable and not have to worry about
> the details. Also, the related code is removed from the board files and
> replaced with the new clock registration functions.
> 
> Signed-off-by: David Lechner <david@lechnology.com>
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> ---
> 
> I have added "ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable"
> from Axel Haslam to this patch.
> 
> In the review of Axel's patch, Sekhar said:
> 
>> We should not be using a NULL device pointer here. Can you pass the musb
>> device pointer available in the same file? Also, da850_clks[] in da850.c
>> needs to be fixed to add the matching device name.
> 
> However, the musb device may not be registered. The usb20_clk can be used to
> supply a 48MHz clock to USB 1.1 (ohci) without using the musb device. So, I am
> inclined to leave this as NULL.

But clock look-up has nothing to do with device being registered AFAICT.
It is used to identify the clock consumer. Passing NULL there means the
clock is not associated with any device. Which is not correct as we are
specifically looking at MUSB module clock.

Thanks,
Sekhar

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/5] da8xx USB PHY platform devices and clocks David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
  [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
    Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node Sekhar Nori <nsekhar@ti.com> - 2016-10-26 12:30 +0200
    Re: [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node David Lechner <david@lechnology.com> - 2016-10-26 18:10 +0200
  [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
    Re: [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node Sekhar Nori <nsekhar@ti.com> - 2016-10-26 12:30 +0200
  [PATCH v6 3/5] ARM: davinci: da8xx: Add USB PHY platform declaration David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
  [PATCH v6 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
    Re: [PATCH v6 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform  declaration. Sekhar Nori <nsekhar@ti.com> - 2016-10-26 12:00 +0200
  [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-10-26 05:10 +0200
    Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-10-26 10:10 +0200
      Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-10-26 18:40 +0200
        Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-10-26 19:20 +0200
    Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-10-26 11:30 +0200

csiph-web