Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol warnings

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Sekhar Nori <nsekhar@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol warnings
Date	Thu, 27 Oct 2016 16:50:01 +0200
Message-ID	<swTnR-2Bn-101@gated-at.bofh.it> (permalink)
References	<swvET-3Eq-81@gated-at.bofh.it> <swvOy-3Ml-47@gated-at.bofh.it>
X-Original-To	Alexandre Bailon <abailon@baylibre.com>, <gregkh@linuxfoundation.org>, <khilman@baylibre.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Thu, 27 Oct 2016 17:13:13 +0530
X-Original-Message-ID	<7026f012-ffce-cc28-85be-9a5cd26de60f@ti.com>
X-Original-References	<1477485542-10555-1-git-send-email-abailon@baylibre.com> <1477485542-10555-2-git-send-email-abailon@baylibre.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1510321

Show key headers only | View raw

On Wednesday 26 October 2016 06:09 PM, Alexandre Bailon wrote:
> Some macro for DA8xx CFGCHIP are defined in usb-davinci.h,
> but da8xx-cfgchip.h intend to replace them.
> The usb-da8xx.c is using both headers, causing redefined symbol warnings.

Looks like this is not true for v4.9-rc2 and so I don't see any warnings
in v4.9-rc2. This is probably introduced due to some changes you are
doing for v4.10 and so it is not a v4.9-rc candidate.

> Remove the macro and update the board files to use da8xx-cfgchip.h

This patch should probably be folded into the patch which actually
introduces da8xx-cfgchip.h into usb-da8xx.c

> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

Thanks,
Sekhar

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] Fix some potential warnings Alexandre Bailon <abailon@baylibre.com> - 2016-10-26 14:40 +0200
  [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol warnings Alexandre Bailon <abailon@baylibre.com> - 2016-10-26 14:50 +0200
    Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol  warnings Sekhar Nori <nsekhar@ti.com> - 2016-10-27 16:00 +0200
      Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol  warnings Alexandre Bailon <abailon@baylibre.com> - 2016-10-27 16:40 +0200
    Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol  warnings Sekhar Nori <nsekhar@ti.com> - 2016-10-27 16:50 +0200

csiph-web