Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1510320

Re: [PATCH V3] mfd: wm8994-core: Don't use managed regulator bulk get API

Show all headers | View raw

On 27-10-16, 10:14, Charles Keepax wrote:
> On Thu, Oct 27, 2016 at 09:09:30AM +0530, Viresh Kumar wrote:
> > The kernel WARNs and then crashes today if wm8994_device_init() fails
> > after calling devm_regulator_bulk_get().
> > 
> > That happens because there are multiple devices involved here and the
> > order in which resources are freed isn't correct.
> > 
> > The regulators are added as children of wm8994->dev.
> > devm_regulator_bulk_get() receives wm8994->dev as the device, though it
> > gets the same regulators which were added as children of wm8994->dev
> > earlier.
> > 
> > During failures, the children are removed first and the core eventually
> > calls regulator_unregister() for them. As regulator_put() was never done
> > for them (opposite of devm_regulator_bulk_get()), the kernel WARNs at
> > 
> > 	WARN_ON(rdev->open_count);
> > 
> > And eventually it crashes from debugfs_remove_recursive().
> > 
> > --------x------------------x----------------
> 
> The back track seems to have got really really long again.

Not just that, even the code moved a version back.

Sorry for the noise, the right version is sent now :(

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-27 05:50 +0200
  Re: [PATCH V3] mfd: wm8994-core: Don't use managed regulator bulk  get API Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-27 11:20 +0200
    Re: [PATCH V3] mfd: wm8994-core: Don't use managed regulator bulk  get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-27 16:50 +0200

csiph-web