Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1509676
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults |
| Date | 2016-10-26 20:20 +0200 |
| Message-ID | <swAXU-7td-5@gated-at.bofh.it> (permalink) |
| References | <su2QF-4lW-3@gated-at.bofh.it> <su3D4-4Wo-19@gated-at.bofh.it> <svStP-31f-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Oct 24, 2016 at 11:47 AM, Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> How about this instead: given that we already mark the shadow entries
> exceptional, and the exceptional bit is part of the radix tree API,
> can we just introduce a node->exceptional counter for those entries
> and have the radix tree code assist us with that instead? It adds the
> counting for non-shadow exceptional entries as well (shmem swap slots,
> and DAX non-page entries), unfortunately, but this is way cleaner. It
> also makes mapping->nrexceptional and node->exceptional consistent in
> DAX (Jan, could you please double check the accounting there?)
>
> What do you think? Lightly tested patch below.
This certainly looks way better to me. I didn't *test* it, but it
doesn't make me scratch my head the way your previous patch did.
Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-19 19:30 +0200
Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-19 20:20 +0200
Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-24 20:50 +0200
Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Jan Kara <jack@suse.cz> - 2016-10-26 11:30 +0200
Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-26 20:20 +0200
Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Jan Kara <jack@suse.cz> - 2016-10-27 11:20 +0200
Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-26 20:20 +0200
Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-26 20:40 +0200
csiph-web