Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1504169

[PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults

Show all headers | View raw

Hi,

this is a follow-up to d3798ae8c6f3 ("mm: filemap: don't plant shadow
entries without radix tree node"). That patch fixed an issue that was
caused mainly by the page cache sneaking special shadow page entries
into the radix tree and relying on subtleties in the radix tree code
to make that work. The fix also had to stop tracking refaults for
single-page files because shadow pages stored as direct pointers in
radix_tree_root->rnode weren't properly handled during tree extension.

These patches make the radix tree code explicitely support and track
such special entries, to eliminate the subtleties and to restore the
thrash detection for single-page files.

They then turn the BUG_ONs in the shadow shrinker into mere warnings,
to prevent unnecessary crashes such as those mentioned in d3798ae8c6f3.

The changes have been running stable on my main machines for a couple
of days, survived kernel builds, chrome, and various synthetic stress
tests that excercise the shadow page tracking code. They've also been
solid doing scalability and page cache tests from Mel's mmtests.

It's more code, but it should be a lot less fragile. What do you think?

 include/linux/radix-tree.h      |  33 +++++----
 include/linux/swap.h            |  16 +++--
 lib/dma-debug.c                 |   6 +-
 lib/radix-tree.c                | 142 +++++++++++++++++++++++---------------
 mm/filemap.c                    |  25 ++++---
 mm/truncate.c                   |   2 +
 mm/workingset.c                 |  19 +++--
 tools/testing/radix-tree/test.c |   4 +-
 8 files changed, 149 insertions(+), 98 deletions(-)

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-19 19:30 +0200
  Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page  file refaults Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-19 20:20 +0200
    Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page  file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-24 20:50 +0200
      Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page  file refaults Jan Kara <jack@suse.cz> - 2016-10-26 11:30 +0200
        Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page  file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-26 20:20 +0200
      Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page  file refaults Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-26 20:20 +0200
        Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page  file refaults Johannes Weiner <hannes@cmpxchg.org> - 2016-10-26 20:40 +0200

csiph-web