[PATCH] gpio: mxc: Shift generic request/free after gpiochip registration

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Deepak Das <deepak_das@mentor.com>
Newsgroups	linux.kernel
Subject	[PATCH] gpio: mxc: Shift generic request/free after gpiochip registration
Date	Tue, 25 Oct 2016 07:00:01 +0200
Message-ID	<sw209-Rp-3@gated-at.bofh.it> (permalink)
X-Original-To	Linus Walleij <linus.walleij@linaro.org>, <shawnguo@kernel.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	7bit
X-Originating-IP	[137.202.0.87]
X-Clientproxiedby	svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, <Vladimir_Zapolskiy@mentor.com>, <fabio.estevam@nxp.com>, <kernel@pengutronix.de>, <p.zabel@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 25 Oct 2016 10:27:17 +0530
X-Original-Message-ID	<580EE62D.4090704@mentor.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1507969

Show key headers only | View raw

generic gpio request/free should be added after gpiocip registration
to validate mapping of gpiochip with pinctrl subsystem.

gpiochip->pin_ranges list contains the information used by pinctrl
subsystem to configure corresponding pins for gpio usage.
This list will be empty if gpiochip fails to map with
pinctrl subsystem for any reason.
For Ex.:-
generic gpio request/free should not be used if IOMUX pin controller
device node is disabled in device tree.

This commit checks above list and skips adding generic gpio request/free
if list is found empty.

Signed-off-by: Deepak Das <deepak_das@mentor.com>
Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
---
 drivers/gpio/gpio-mxc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index c1a1e00..9f79a9f 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -458,11 +458,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
        if (err)
                goto out_bgio;

-       if (of_property_read_bool(np, "gpio-ranges")) {
-               port->gc.request = gpiochip_generic_request;
-               port->gc.free = gpiochip_generic_free;
-       }
-
        port->gc.to_irq = mxc_gpio_to_irq;
        port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :
                                             pdev->id * 32;
@@ -471,6 +466,11 @@ static int mxc_gpio_probe(struct platform_device *pdev)
        if (err)
                goto out_bgio;

+       if (!list_empty(&port->gc.pin_ranges)) {
+               port->gc.request = gpiochip_generic_request;
+               port->gc.free = gpiochip_generic_free;
+       }
+
        irq_base = irq_alloc_descs(-1, 0, 32, numa_node_id());
        if (irq_base < 0) {
                err = irq_base;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: mxc: Shift generic request/free after gpiochip  registration Deepak Das <deepak_das@mentor.com> - 2016-10-25 07:00 +0200
  Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip registration Linus Walleij <linus.walleij@linaro.org> - 2016-10-25 14:20 +0200
    Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip  registration Deepak Das <deepak_das@mentor.com> - 2016-10-25 14:30 +0200

csiph-web