Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip registration

From	Deepak Das <deepak_das@mentor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip registration
Date	2016-10-25 14:30 +0200
Message-ID	<sw91D-5BL-13@gated-at.bofh.it> (permalink)
References	<sw209-Rp-3@gated-at.bofh.it> <sw8RY-5yg-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Tuesday 25 October 2016 05:41 PM, Linus Walleij wrote:
> On Tue, Oct 25, 2016 at 6:57 AM, Deepak Das <deepak_das@mentor.com> wrote:
> 
>> generic gpio request/free should be added after gpiocip registration
>> to validate mapping of gpiochip with pinctrl subsystem.
>>
>> gpiochip->pin_ranges list contains the information used by pinctrl
>> subsystem to configure corresponding pins for gpio usage.
>> This list will be empty if gpiochip fails to map with
>> pinctrl subsystem for any reason.
>> For Ex.:-
>> generic gpio request/free should not be used if IOMUX pin controller
>> device node is disabled in device tree.
>>
>> This commit checks above list and skips adding generic gpio request/free
>> if list is found empty.
>>
>> Signed-off-by: Deepak Das <deepak_das@mentor.com>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> 
> Third time I find this in my inbox and it still doesn't apply.
> 
> Yours,
> Linus Walleij

Hi Linus,

Sorry for the trouble. Three patches were sent by mistake. I am rebasing this patch on top of your gpio fixes branch.
This might not be required for stable branch since the original patch 
4c806c9 "gpio: mxc: add generic gpio request/free callbacks to pinctrl" was included in v4.9 so this cane be added in
v4.9 fixes.

with warm regards,
Deepak Das
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: mxc: Shift generic request/free after gpiochip  registration Deepak Das <deepak_das@mentor.com> - 2016-10-25 07:00 +0200
  Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip registration Linus Walleij <linus.walleij@linaro.org> - 2016-10-25 14:20 +0200
    Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip  registration Deepak Das <deepak_das@mentor.com> - 2016-10-25 14:30 +0200

csiph-web