Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507184

Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

From "Luc, Piotr" <Piotr.Luc@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros
Date 2016-10-24 15:20 +0200
Message-ID <svNkt-841-9@gated-at.bofh.it> (permalink)
References <srQgV-5jv-3@gated-at.bofh.it> <srQgW-5jv-33@gated-at.bofh.it> <ss9tg-15v-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote:
> On Thu, 13 Oct 2016, Piotr Luc wrote:

> > 
> > +	case INTEL_FAM6_SANDYBRIDGE:		/* SNB */
> 
> Especialy those, which are completely useless?
> 
> The defines are there to be self explaining and the extra verbose
> information should be in the header file defining the macros and not
> in the
> source code.

Hi

I submitted the turbostat patchset 
https://lkml.kernel.org/r/20161018210652.29365-1-piotr.luc@intel.com to
address the issues.

Regards
Piotr

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH 00/11] Add Knights Mill CPU ID Piotr Luc <piotr.luc@intel.com> - 2016-10-13 17:40 +0200
  [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros Piotr Luc <piotr.luc@intel.com> - 2016-10-13 17:40 +0200
    Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor  macros Thomas Gleixner <tglx@linutronix.de> - 2016-10-14 14:10 +0200
      Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family  processor macros "Luc, Piotr" <Piotr.Luc@intel.com> - 2016-10-24 15:20 +0200
  [RESEND PATCH 04/11] x86/intel_idle: Add Knights Mill CPUID Piotr Luc <piotr.luc@intel.com> - 2016-10-13 17:40 +0200
    Re: [RESEND,04/11] x86/intel_idle: Add Knights Mill CPUID "Luc, Piotr" <Piotr.Luc@intel.com> - 2016-10-25 12:40 +0200
  [RESEND PATCH 09/11] perf/x86/intel/uncore: Add Knights Mill CPUID Piotr Luc <piotr.luc@intel.com> - 2016-10-13 17:40 +0200
  [RESEND PATCH 08/11] perf/x86/intel/rapl: Add Knights Mill CPUID Piotr Luc <piotr.luc@intel.com> - 2016-10-13 17:40 +0200
  Re: [RESEND PATCH 00/11] Add Knights Mill CPU ID "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-10-14 00:00 +0200
    Re: [RESEND PATCH 00/11] Add Knights Mill CPU ID "Luc, Piotr" <Piotr.Luc@intel.com> - 2016-10-24 18:20 +0200

csiph-web