Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507183

Re: [PATCH 1/4] MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()

From Theodore Ts'o <tytso@mit.edu>
Newsgroups linux.kernel
Subject Re: [PATCH 1/4] MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()
Date 2016-10-24 15:20 +0200
Message-ID <svNkt-841-3@gated-at.bofh.it> (permalink)
References <svMy5-7xJ-9@gated-at.bofh.it> <svMy5-7xJ-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 24, 2016 at 02:27:55PM +0200, SF Markus Elfring wrote:
> 
> A string which did not contain a data format specification should be put
> into a sequence.

This is not a correct description of what you are doing.  A better
description would be to say:

"Use seq_put[sc]() instead of seq_printf() since the string does not
contain a data format specifier".  You should fix this in all the
patches.  Please also note this is really pointless patch, since
reading from /proc isn't done in a tight loop, and even if it were,
the use of vsprintf is the tiniest part of the overhead.  It otherwise
reduces the text space or the number of lines of code....

					- Ted

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] MIPS/kernel/r2-to-r6-emul: Use seq_puts() in  mipsr2_stats_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-24 14:30 +0200
  Re: [PATCH 1/4] MIPS/kernel/r2-to-r6-emul: Use seq_puts() in  mipsr2_stats_show() Theodore Ts'o <tytso@mit.edu> - 2016-10-24 15:20 +0200
    Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-24 16:10 +0200
      Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show() Theodore Ts'o <tytso@mit.edu> - 2016-10-24 16:30 +0200
        Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-24 17:00 +0200
          Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show() Theodore Ts'o <tytso@mit.edu> - 2016-10-24 18:00 +0200
            Re: Further software improvements around Linux sequence API? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-24 20:20 +0200

csiph-web