Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1507064

Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible
Date 2016-10-24 12:20 +0200
Message-ID <svKwi-6el-19@gated-at.bofh.it> (permalink)
References <sv0D7-1uS-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks this function with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] drm/i2c/tda998x: mark symbol static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-10-22 11:20 +0200
  Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible Arnd Bergmann <arnd@arndb.de> - 2016-10-24 12:20 +0200
    Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible Daniel Vetter <daniel@ffwll.ch> - 2016-10-24 16:30 +0200

csiph-web