[PATCH] drm/i2c/tda998x: mark symbol static where possible

From	Baoyou Xie <baoyou.xie@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH] drm/i2c/tda998x: mark symbol static where possible
Date	2016-10-22 11:20 +0200
Message-ID	<sv0D7-1uS-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We get 1 warning when building kernel with W=1:
drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 9798d40..af8683e 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1289,7 +1289,8 @@ static void tda998x_audio_shutdown(struct device *dev, void *data)
 	mutex_unlock(&priv->audio_mutex);
 }
 
-int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable)
+static int
+tda998x_audio_digital_mute(struct device *dev, void *data, bool enable)
 {
 	struct tda998x_priv *priv = dev_get_drvdata(dev);
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i2c/tda998x: mark symbol static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-10-22 11:20 +0200
  Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible Arnd Bergmann <arnd@arndb.de> - 2016-10-24 12:20 +0200
    Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible Daniel Vetter <daniel@ffwll.ch> - 2016-10-24 16:30 +0200

csiph-web