Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1506819
| From | Nicholas Piggin <npiggin@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm |
| Date | 2016-10-24 03:30 +0200 |
| Message-ID | <svCfn-DO-7@gated-at.bofh.it> (permalink) |
| References | <suKI2-84M-23@gated-at.bofh.it> <suRJw-43G-9@gated-at.bofh.it> <sv9Q5-7sn-9@gated-at.bofh.it> |
| Organization | IBM |
On Sat, 22 Oct 2016 15:08:52 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > On Sat, 22 Oct 2016 10:44:41 +1100 > Nicholas Piggin <npiggin@gmail.com> wrote: > > > > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > > > diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h > > > index 43199a049da5..cb86e746865e 100644 > > > --- a/include/asm-generic/export.h > > > +++ b/include/asm-generic/export.h > > > @@ -90,5 +90,10 @@ > > > __EXPORT_SYMBOL(name, KSYM(name),) > > > #define EXPORT_DATA_SYMBOL_GPL(name) \ > > > __EXPORT_SYMBOL(name, KSYM(name),_gpl) > > > +/* > > > + * If "name" is a macro of a function and not a function itself, > > > + * it needs a second pass. > > > + */ > > > +#define EXPORT_MACRO_SYMBOL(x) EXPORT_SYMBOL(x) > > > > Seems okay, but what about just calling it EXPORT_SYMBOL? > > > Actually, this doesn't work. There's some magic going on it > Makefile.build in the scripts directory that causes this to fail. > > I have another patch I'll be sending on Monday that fixes this. Yes it's grepping for EXPORT_SYMBOL_* I think. If you need to create a new name, EXPORT_SYMBOL prefix would be preferred. But yeah if you make the standard macro do macro expansion, it should just work, no?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm Steven Rostedt <rostedt@goodmis.org> - 2016-10-21 18:20 +0200
Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm Nicholas Piggin <npiggin@gmail.com> - 2016-10-22 01:50 +0200
Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm Steven Rostedt <rostedt@goodmis.org> - 2016-10-22 21:10 +0200
Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm Nicholas Piggin <npiggin@gmail.com> - 2016-10-24 03:30 +0200
Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm Steven Rostedt <rostedt@goodmis.org> - 2016-10-24 16:20 +0200
csiph-web