Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

From	"Jin, Yao" <yao.jin@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain
Date	2016-10-21 02:30 +0200
Message-ID	<suvSF-6p0-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <su1UD-3KZ-47@gated-at.bofh.it> <suoHv-1G4-5@gated-at.bofh.it> <suoHw-1G4-15@gated-at.bofh.it> <sup0R-21Y-17@gated-at.bofh.it> <suqgi-2Md-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andi, Hi Nilay,

Thanks so much for your comments!

I will upgrade the patch to just display the count for abort.

Thanks

Jin Yao

On 10/21/2016 2:20 AM, Andi Kleen wrote:
>> OK, I am more confused now.  Are you predicting some quantity related
>> to transactions?  Why would you divide abort count by branch count?
>> Further, I just looked at patch 6/6.  It has the following text:
>>
>> + Also show with some branch flags that can be:
>> + - Predicted: display the average percentage of predicated branches.
>> +     (predicated number / total number)
>> + - Abort: display the average percentage of abort branches.
>> + (abort number /total number)
>> + - Cycles: cycles in basic block.
>>
>>
>> I think there is inconsistency between what you are suggesting and
>> what the patch has.
> An abort is an unique branch. But yes there is no total number,
> so the formula will always be 100%. So yes would probably be
> better to just display a count for abort.
>
> -Andi

Thread

[PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain Jin Yao <yao.jin@linux.intel.com> - 2016-10-19 18:30 +0200
  Re: [PATCH v2 2/6] perf report: Caculate and return the branch  counting in callchain Nilay Vaish <nilayvaish@gmail.com> - 2016-10-20 18:50 +0200
    Re: [PATCH v2 2/6] perf report: Caculate and return the branch  counting in callchain Andi Kleen <ak@linux.intel.com> - 2016-10-20 18:50 +0200
      Re: [PATCH v2 2/6] perf report: Caculate and return the branch  counting in callchain Nilay Vaish <nilayvaish@gmail.com> - 2016-10-20 19:10 +0200
        Re: [PATCH v2 2/6] perf report: Caculate and return the branch  counting in callchain Andi Kleen <ak@linux.intel.com> - 2016-10-20 20:30 +0200
          Re: [PATCH v2 2/6] perf report: Caculate and return the branch  counting in callchain "Jin, Yao" <yao.jin@linux.intel.com> - 2016-10-21 02:30 +0200
            Re: [PATCH v2 2/6] perf report: Caculate and return the branch  counting in callchain Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-25 20:20 +0200

csiph-web