Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505213

Re: [PATCH] acpi/apei: Fix in-correct return value

Show all headers | View raw

On 10/18/2016 10:07 AM, Punit Agrawal wrote:
> Although ghes_proc tests for error while reading the error status, it
> always return success (0). Fix this by propagating the return value.
>
> Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support")
> Signed-of-by: Punit Agrawal <punit.agrawa.@arm.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
Tested-by: Tyler Baicar <tbaicar@codeaurora.org>

Thanks,
Tyler
> ---
>   drivers/acpi/apei/ghes.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index f0a029e..0d099a2 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes)
>   	ghes_do_proc(ghes, ghes->estatus);
>   out:
>   	ghes_clear_estatus(ghes);
> -	return 0;
> +	return rc;
>   }
>   
>   static void ghes_add_timer(struct ghes *ghes)

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi/apei: Fix in-correct return value Punit Agrawal <punit.agrawal@arm.com> - 2016-10-18 18:10 +0200
  Re: [PATCH] acpi/apei: Fix in-correct return value "Baicar, Tyler" <tbaicar@codeaurora.org> - 2016-10-20 22:00 +0200
    Re: [PATCH] acpi/apei: Fix in-correct return value Punit Agrawal <punit.agrawal@arm.com> - 2016-10-21 17:00 +0200
  Re: [PATCH] acpi/apei: Fix in-correct return value "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-10-21 23:30 +0200
    Re: [PATCH] acpi/apei: Fix in-correct return value Borislav Petkov <bp@suse.de> - 2016-10-22 19:40 +0200
      Re: [PATCH] acpi/apei: Fix in-correct return value "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-10-23 02:10 +0200

csiph-web