Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo()

From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo()
Date	2016-10-21 17:50 +0200
Message-ID	<suKeZ-7AT-17@gated-at.bofh.it> (permalink)
References	<suBEK-1Rz-51@gated-at.bofh.it> <suCr7-2ns-7@gated-at.bofh.it> <suDZT-3tk-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 21, 2016 at 11:00:22AM +0200, SF Markus Elfring wrote:
> 
> > It is harder to see how the arguments fit into the strings
> > and it is harder to see where the strings end and the arguments begin.
> 
> Is it really so difficult to interpret the suggested construction
> of a single (and relatively small) format string?

It's not so difficult, so much as it makes things worse.  It's easier
the way it originally was.  It might be interesting to see if the
compiler could be taught to collapse the function calls, but (a) this
isn't performance critical, and (b) the number of bytes saved is
really tiny.  But at least if the compiler was doing the work, it
would at least deal with it everywhere.

					- Ted

Thread

[PATCH] Hexagon-setup: Combine four seq_printf() calls into one call  in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 08:40 +0200
  Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one  call in show_cpuinfo() Julia Lawall <julia.lawall@lip6.fr> - 2016-10-21 09:30 +0200
    Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one  call in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 11:10 +0200
      Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one  call in show_cpuinfo() Theodore Ts'o <tytso@mit.edu> - 2016-10-21 17:50 +0200
        Re: Hexagon-setup: Combine four seq_printf() calls into one call in  show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 19:40 +0200
          Re: Hexagon-setup: Combine four seq_printf() calls into one call in  show_cpuinfo() Theodore Ts'o <tytso@mit.edu> - 2016-10-21 20:00 +0200
            Re: Hexagon-setup: Combine four seq_printf() calls into one call in  show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 21:00 +0200
              Re: Hexagon-setup: Combine four seq_printf() calls into one call in  show_cpuinfo() Richard Kuo <rkuo@codeaurora.org> - 2016-10-25 23:50 +0200
            Re: Hexagon-setup: Combine four seq_printf() calls into one call in  show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-23 08:30 +0200

csiph-web