Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1505605
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() |
| Date | 2016-10-21 11:10 +0200 |
| Message-ID | <suDZT-3tk-15@gated-at.bofh.it> (permalink) |
| References | <suBEK-1Rz-51@gated-at.bofh.it> <suCr7-2ns-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> +++ b/arch/hexagon/kernel/setup.c >> @@ -132,13 +132,14 @@ static int show_cpuinfo(struct seq_file *m, void *v) >> if (!cpu_online(cpu)) >> return 0; >> #endif >> - >> - seq_printf(m, "processor\t: %d\n", cpu); >> - seq_printf(m, "model name\t: Hexagon Virtual Machine\n"); >> - seq_printf(m, "BogoMips\t: %lu.%02lu\n", >> - (loops_per_jiffy * HZ) / 500000, >> - ((loops_per_jiffy * HZ) / 5000) % 100); >> - seq_printf(m, "\n"); >> + seq_printf(m, >> + "processor\t: %d\n" >> + "model name\t: Hexagon Virtual Machine\n" >> + "BogoMips\t: %lu.%02lu\n" >> + "\n", >> + cpu, >> + (loops_per_jiffy * HZ) / 500000, >> + ((loops_per_jiffy * HZ) / 5000) % 100); > > This looks completely pointless. Thanks for your software development opinion in this use case. > It is harder to see how the arguments fit into the strings > and it is harder to see where the strings end and the arguments begin. Is it really so difficult to interpret the suggested construction of a single (and relatively small) format string? Regards, Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 08:40 +0200
Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() Julia Lawall <julia.lawall@lip6.fr> - 2016-10-21 09:30 +0200
Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 11:10 +0200
Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() Theodore Ts'o <tytso@mit.edu> - 2016-10-21 17:50 +0200
Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 19:40 +0200
Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() Theodore Ts'o <tytso@mit.edu> - 2016-10-21 20:00 +0200
Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 21:00 +0200
Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() Richard Kuo <rkuo@codeaurora.org> - 2016-10-25 23:50 +0200
Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-23 08:30 +0200
csiph-web