Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505773

Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported

Show all headers | View raw

On Fri, 2016-10-21 at 10:56 +0100, Luis Oliveira wrote:
> Since practically 90% of the code is shared between master and slave,
> I was
> thinking if it will be acceptable to use the same driver for both but
> differentiate the master/slave mode by the compatible strings.

It might be possible to split like other drivers do:

1. Core part (i2c-designware-core.c)
2. Master part (i2c-designware-master.c)
3. Slave part (i2c-designware-slave.c)
4. Glue drivers (like: i2c-designware-platdrv.c)

> 
> Thanks,
> Luis
> 
> On 10/18/2016 16:17, Wolfram Sang wrote:
> > > This is needed because the configuration is different and the i2c-
> > > designware
> > > cannot be master/slave without a reset. To resolve that I added
> > > this property
> > > to bind it as a slave when needed.
> > 
> > Aww, pity that the HW can't do that. Do you have details why?
> > 
> > If that is really a HW limitation, then I'd suggest having a
> > seperate
> > driver for slave-only mode so we can differentiate by compatible
> > strings.
> > 
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] Add slave mode to Synopsys I2C driver Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
  [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
    Re: [PATCH v2 3/4] Device bindings documentation updated  ACPI-enabled platforms not currently supported Mark Rutland <mark.rutland@arm.com> - 2016-10-14 19:40 +0200
      Re: [PATCH v2 3/4] Device bindings documentation updated  ACPI-enabled platforms not currently supported Wolfram Sang <wsa@the-dreams.de> - 2016-10-14 20:30 +0200
        Re: [PATCH v2 3/4] Device bindings documentation updated  ACPI-enabled platforms not currently supported Wolfram Sang <wsa@the-dreams.de> - 2016-10-18 17:20 +0200
          Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled  platforms not currently supported Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-10-21 12:00 +0200
            Re: [PATCH v2 3/4] Device bindings documentation updated  ACPI-enabled platforms not currently supported Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 13:00 +0200
      Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled  platforms not currently supported Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2016-10-18 17:00 +0200
    Re: [PATCH v2 3/4] Device bindings documentation updated  ACPI-enabled platforms not currently supported Rob Herring <robh@kernel.org> - 2016-10-18 16:40 +0200
  [PATCH v2 2/4] Added I2C_SLAVE as a dependency to I2C_DESIGNWARE_CORE Enable _slave() mode Review of the pm_runtime...() methods and cleaning Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
    Re: [PATCH v2 2/4] Added I2C_SLAVE as a dependency to  I2C_DESIGNWARE_CORE Enable _slave() mode Review of the pm_runtime...()  methods and cleaning Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 13:00 +0200
  [PATCH v2 1/4] Factor out _master() parts of code and identify as much as possible all related with MASTER mode Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
    Re: [PATCH v2 1/4] Factor out _master() parts of code and identify  as much as possible all related with MASTER mode Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 12:40 +0200
  [PATCH v2 4/4] Cleaned the code, no functional changes. Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
    Re: [PATCH v2 4/4] Cleaned the code, no functional changes. Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 13:00 +0200

csiph-web