Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501109
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported |
| Date | 2016-10-14 19:40 +0200 |
| Message-ID | <sseCB-4ie-3@gated-at.bofh.it> (permalink) |
| References | <ssdZY-3Nv-3@gated-at.bofh.it> <ssdZY-3Nv-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Oct 14, 2016 at 05:52:50PM +0100, Luis.Oliveira@synopsys.com wrote: > - is_slave = device_property_read_bool(&pdev->dev, "isslave"); Which tree is this based on? I cant see the existing isslave property in mainline HEAD (commit 29fbff8698fc0ac1). > +#ifndef CONFIG_ACPI > + is_slave = device_property_read_bool(&pdev->dev, "is-slave"); > +#endif This ifdef is broken. At least for arm64, a single kernel image can be booted with either ACPI or DT. We need separate accessors for DT and ACPI to handle these differently, or you need to explicitly check whether or not you have ACPI or DT at runtime. Thanks, Mark.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/4] Add slave mode to Synopsys I2C driver Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
[PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Mark Rutland <mark.rutland@arm.com> - 2016-10-14 19:40 +0200
Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Wolfram Sang <wsa@the-dreams.de> - 2016-10-14 20:30 +0200
Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Wolfram Sang <wsa@the-dreams.de> - 2016-10-18 17:20 +0200
Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-10-21 12:00 +0200
Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 13:00 +0200
Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2016-10-18 17:00 +0200
Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Rob Herring <robh@kernel.org> - 2016-10-18 16:40 +0200
[PATCH v2 2/4] Added I2C_SLAVE as a dependency to I2C_DESIGNWARE_CORE Enable _slave() mode Review of the pm_runtime...() methods and cleaning Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
Re: [PATCH v2 2/4] Added I2C_SLAVE as a dependency to I2C_DESIGNWARE_CORE Enable _slave() mode Review of the pm_runtime...() methods and cleaning Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 13:00 +0200
[PATCH v2 1/4] Factor out _master() parts of code and identify as much as possible all related with MASTER mode Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
Re: [PATCH v2 1/4] Factor out _master() parts of code and identify as much as possible all related with MASTER mode Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 12:40 +0200
[PATCH v2 4/4] Cleaned the code, no functional changes. Luis.Oliveira@synopsys.com - 2016-10-14 19:00 +0200
Re: [PATCH v2 4/4] Cleaned the code, no functional changes. Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-21 13:00 +0200
csiph-web