Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1505566

Re: [PATCH 1/2] mmc: mediatek: Fix module autoload

From Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] mmc: mediatek: Fix module autoload
Date 2016-10-21 10:30 +0200
Message-ID <suDnc-30q-13@gated-at.bofh.it> (permalink)
References <stiNP-5MT-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 17 October 2016 at 18:13, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> alias:          of:N*T*Cmediatek,mt8135-mmcC*
> alias:          of:N*T*Cmediatek,mt8135-mmc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/mtk-sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 84e9afcb5c09..86af0b199a54 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1713,6 +1713,7 @@ static const struct of_device_id msdc_of_ids[] = {
>         {   .compatible = "mediatek,mt8135-mmc", },
>         {}
>  };
> +MODULE_DEVICE_TABLE(of, msdc_of_ids);
>
>  static struct platform_driver mt_msdc_driver = {
>         .probe = msdc_drv_probe,
> --
> 2.7.4
>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] mmc: mediatek: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 18:20 +0200
  [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 18:20 +0200
    Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Ludovic Desroches <ludovic.desroches@atmel.com> - 2016-10-21 08:50 +0200
      Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Adrian Hunter <adrian.hunter@intel.com> - 2016-10-21 09:30 +0200
    Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-21 10:30 +0200
  Re: [PATCH 1/2] mmc: mediatek: Fix module autoload Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-21 10:30 +0200

csiph-web