Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505565

Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload

Show all headers | View raw

On 17 October 2016 at 18:13, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> alias:          of:N*T*Catmel,sama5d2-sdhciC*
> alias:          of:N*T*Catmel,sama5d2-sdhci
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/sdhci-of-at91.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index a9b7fc06c434..2f9ad213377a 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>         { .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>         {}
>  };
> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>
>  #ifdef CONFIG_PM
>  static int sdhci_at91_runtime_suspend(struct device *dev)
> --
> 2.7.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mmc: mediatek: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 18:20 +0200
  [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 18:20 +0200
    Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Ludovic Desroches <ludovic.desroches@atmel.com> - 2016-10-21 08:50 +0200
      Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Adrian Hunter <adrian.hunter@intel.com> - 2016-10-21 09:30 +0200
    Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-21 10:30 +0200
  Re: [PATCH 1/2] mmc: mediatek: Fix module autoload Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-21 10:30 +0200

csiph-web