Groups > linux.kernel > #1501938

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()
Date	2016-10-17 14:40 +0200
Message-ID	<stfmW-3uj-21@gated-at.bofh.it> (permalink)
References	<ssYYO-1qy-21@gated-at.bofh.it> <stdOa-2ot-11@gated-at.bofh.it> <steqS-2QN-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 17, 2016 at 01:30:59PM +0200, SF Markus Elfring wrote:
> >> Some data were printed into a sequence by six separate function calls.
> >> Print the same data by a single function call instead.
> > 
> > ... why?
> > 
> > Beyond simply having fewer function calls, is there an upside?
> 
> Will it matter to improve run time characteristics at this source code
> place?

I do not know. If that's not the aim of your existing patch, then I have
no idea what you're trying to achieve.

> > This makes it harder to see the relationship between the format strings
> > and their associated data, and makes the code longer.
> 
> Do you prefer an other layout for the passed data so that the increase
> of line count in my update suggestion would look differently?

I prefer the code as-is. Unless there's a compelling reason to change
it.

Thanks,
Mark.

Thread

[PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-16 21:10 +0200
  Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output into  one seq_printf() call in c_show() Matthias Brugger <matthias.bgg@gmail.com> - 2016-10-17 12:00 +0200
  Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output  into one seq_printf() call in c_show() Mark Rutland <mark.rutland@arm.com> - 2016-10-17 13:00 +0200
    Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 13:40 +0200
      Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() Mark Rutland <mark.rutland@arm.com> - 2016-10-17 14:40 +0200
        Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 15:00 +0200
          Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() Mark Rutland <mark.rutland@arm.com> - 2016-10-17 15:20 +0200

csiph-web