Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501900

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()
Date 2016-10-17 13:40 +0200
Message-ID <steqS-2QN-25@gated-at.bofh.it> (permalink)
References <ssYYO-1qy-21@gated-at.bofh.it> <stdOa-2ot-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

>> Some data were printed into a sequence by six separate function calls.
>> Print the same data by a single function call instead.
> 
> ... why?
> 
> Beyond simply having fewer function calls, is there an upside?

Will it matter to improve run time characteristics at this source code place?


> This makes it harder to see the relationship between the format strings
> and their associated data, and makes the code longer.

Do you prefer an other layout for the passed data so that the increase
of line count in my update suggestion would look differently?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-16 21:10 +0200
  Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output into  one seq_printf() call in c_show() Matthias Brugger <matthias.bgg@gmail.com> - 2016-10-17 12:00 +0200
  Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output  into one seq_printf() call in c_show() Mark Rutland <mark.rutland@arm.com> - 2016-10-17 13:00 +0200
    Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 13:40 +0200
      Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() Mark Rutland <mark.rutland@arm.com> - 2016-10-17 14:40 +0200
        Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 15:00 +0200
          Re: ARM64-cpuinfo: Combine six calls for sequence output into one  seq_printf() call in c_show() Mark Rutland <mark.rutland@arm.com> - 2016-10-17 15:20 +0200

csiph-web