Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json files

From	Andi Kleen <andi@firstfloor.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json files
Date	2016-10-14 17:40 +0200
Message-ID	<sscKu-36Y-11@gated-at.bofh.it> (permalink)
References	<srVzX-qJ-3@gated-at.bofh.it> <srVzX-qJ-1@gated-at.bofh.it> <ss9MC-1cq-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> >  				addfield(map, &extra_desc, ". ",
> >  					" Supports address when precise",
> >  					NULL);
> > +			} else if (json_streq(map, field, "Unit")) {
> 
> so I remember you said you're preparing JSON events files for perf,
> so why not call this field "Pmu" directly? Would be less confusing
> wrt the ScaleUnit field

While I'm cleaning up the files somewhat, I'm still trying to be
compatible with the original format, so that it's also possible
to drop in unchanged files. Also it's better if there is only
one kind of JSON event format, not multiple subtle incompatible
versions.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 03/10] perf, tools: Add support for parsing uncore json files Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 11:10 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 14:20 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 14:30 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 14:30 +0200
    Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Andi Kleen <andi@firstfloor.org> - 2016-10-14 17:40 +0200

csiph-web