Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1500880

Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json files

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json files
Date 2016-10-14 14:20 +0200
Message-ID <ss9CW-197-9@gated-at.bofh.it> (permalink)
References <srVzX-qJ-3@gated-at.bofh.it> <srVzX-qJ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Oct 13, 2016 at 02:15:25PM -0700, Andi Kleen wrote:

SNIP

> @@ -376,6 +412,16 @@ int json_events(const char *fn,
>  			nz = !json_streq(map, val, "0");
>  			if (match_field(map, field, nz, &event, val)) {
>  				/* ok */
> +			} else if (json_streq(map, field, "EventCode")) {
> +				char *code = NULL;
> +				addfield(map, &code, "", "", val);
> +				eventcode |= strtoul(code, NULL, 0);
> +				free(code);
> +			} else if (json_streq(map, field, "ExtSel")) {
> +				char *code = NULL;
> +				addfield(map, &code, "", "", val);
> +				eventcode |= strtoul(code, NULL, 0) << 21;
> +				free(code);

could you please separate this (EventCode/ExtSel) change from the rest?


thanks,
jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 03/10] perf, tools: Add support for parsing uncore json files Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 11:10 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 14:20 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 14:30 +0200
  Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2016-10-14 14:30 +0200
    Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json  files Andi Kleen <andi@firstfloor.org> - 2016-10-14 17:40 +0200

csiph-web