Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1499382

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Show all headers | View raw

Hi Chris,
On Tue, 2016-10-11 at 09:09 -0500, Chris Rorvick wrote:
> On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > > This is not coming from the NIC itself, but from the platform's ACPI
> > > tables.  Can you tell us which platform you are using?
> 
> 
> Interesting.  I'm running a Dell XPS 13 9350.  I replaced the
> factory-provided Broadcom card with an AC 8260.  I can update the
> commit log to reflect this.

Okay, so this makes sense.  Those entries are probably formatted for
the Broadcom card, which the iwlwifi driver obviously doesn't
understand.  The best we can do, as I already said, is to ignore values
we don't understand.

I will also check what is the correct procedure in such cases, because
it is possible, in theory, that the format *matches* but applies only
to another device.


> > > If this is really bothering you, I guess I could apply this patch for
> > > now.  But as I said, this is not solving the actual problem.
> > 
> > 
> > Bikeshedding: I think IWL_INFO() is more appropriate, as info doesn't
> > imply one needs to act on this message, while warn does imply that
> > action is needed.
> 
> 
> Agreed.  I still think making this a warning is appropriate, but it
> seems pretty clear this is not an error.  This has nothing to do with
> how much it bothers me.  An error tells the user something needs to be
> fixed, but in this case the interface is working fine.  Making it a
> warning with an improved message will result in fewer people wasting
> their time.

Yes, so I'll try to stop wasting people's timing by trying to do the
correct thing without bothering the user at all. :)

Thanks for pointing this all out!

--
Cheers,
Luca.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-10 09:20 +0200
  Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-10 16:10 +0200
    Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-11 12:20 +0200
      Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-11 16:20 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-11 16:30 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 09:00 +0200
      Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 06:40 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 14:30 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 14:50 +0200
            Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 15:30 +0200
      Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 08:20 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 09:00 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 20:00 +0200
            Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 20:10 +0200
              Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 20:40 +0200

csiph-web