Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

From	Chris Rorvick <chris@rorvick.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning
Date	2016-10-11 16:30 +0200
Message-ID	<sr6e5-7Rm-33@gated-at.bofh.it> (permalink)
References	<sqD2q-6Kh-37@gated-at.bofh.it> <sqJrc-2eB-27@gated-at.bofh.it> <sr2ka-5sy-31@gated-at.bofh.it> <sr64p-7NX-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 11, 2016 at 9:09 AM, Chris Rorvick <chris@rorvick.com> wrote:
> I didn't receive your email so I'll try to respond via Paul's.

>>> If this is really bothering you, I guess I could apply this patch for
>>> now.  But as I said, this is not solving the actual problem.
>>
>> Bikeshedding: I think IWL_INFO() is more appropriate, as info doesn't
>> imply one needs to act on this message, while warn does imply that
>> action is needed.
>
> Agreed.  I still think making this a warning is appropriate, but it
> seems pretty clear this is not an error.  This has nothing to do with
> how much it bothers me.  An error tells the user something needs to be
> fixed, but in this case the interface is working fine.  Making it a
> warning with an improved message will result in fewer people wasting
> their time.

I found your original email on lkml.org... should have looked there in
the first place!  Yes, if there is a fix for the underlying issue then
that is obviously preferred.  When I investigated this I saw several
reports spanning at least a few distros and kernel versions with at
least some concluding "this is normal".

Again, thanks!

Chris

Thread

[PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-10 09:20 +0200
  Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-10 16:10 +0200
    Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-11 12:20 +0200
      Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-11 16:20 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-11 16:30 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 09:00 +0200
      Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 06:40 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 14:30 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 14:50 +0200
            Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 15:30 +0200
      Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 08:20 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 09:00 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 20:00 +0200
            Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 20:10 +0200
              Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 20:40 +0200

csiph-web