Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1499361

Re: [PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS for brace issues

Show all headers | View raw

On Wed, Oct 12, 2016 at 5:19 AM, Chase Metzger <chasemetzger15@gmail.com> wrote:
> Added braces for else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
>  drivers/staging/greybus/audio_topology.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index b625169..3a2678e 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -1044,8 +1044,10 @@ static int gbaudio_tplg_create_widget(struct gbaudio_module_info *module,
>                         control->texts = (const char * const *)
>                                 gb_generate_enum_strings(module, gbenum);
>                         control->items = gbenum->items;
> -               } else
> +               } else {
>                         csize = sizeof(struct gb_audio_control);
> +               }
> +
>                 *w_size += csize;
>                 curr = (void *)curr + csize;
>                 list_add(&control->list, &module->widget_ctl_list);
> @@ -1190,8 +1192,9 @@ static int gbaudio_tplg_process_kcontrols(struct gbaudio_module_info *module,
>                         control->texts = (const char * const *)
>                                 gb_generate_enum_strings(module, gbenum);
>                         control->items = gbenum->items;
> -               } else
> +               } else {
>                         csize = sizeof(struct gb_audio_control);
> +               }
>
>                 list_add(&control->list, &module->ctl_list);
>                 dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id,
> --
> 2.1.4
>
You have already submitted a similar patch available on staging-testing branch:
commit b7e0c9eca426 ("drivers: staging: greybus: Fixed CHECKS for brace issues")

--
thanks,
./va

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS for brace issues Chase Metzger <chasemetzger15@gmail.com> - 2016-10-12 02:00 +0200
  Re: [PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS  for brace issues Vaibhav Agarwal <vaibhav.sr@gmail.com> - 2016-10-12 08:10 +0200

csiph-web