[PATCH] cpufreq: CPPC: Correct desired_perf calculation

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Hoan Tran <hotran@apm.com>
Newsgroups	linux.kernel
Subject	[PATCH] cpufreq: CPPC: Correct desired_perf calculation
Date	Tue, 11 Oct 2016 23:40:01 +0200
Message-ID	<srcWd-3tt-9@gated-at.bofh.it> (permalink)
X-Original-To	"Rafael J. Wysocki" <rjw@rjwysocki.net>, Viresh Kumar <viresh.kumar@linaro.org>, pprakash@codeaurora.org, Al Stone <ahs3@redhat.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm; h=from:to:cc:subject:date:message-id; bh=+H23iTOI7k8Ml+QrZc6qoSMmFm64ENbOYK4K+fWilks=; b=Qdyu3pFet3Nhba09TbBbS1MPBRFc7Otz1Jibw9c1MTg9uEd2XRoM9EcyRX1/9zagK0 T6oD5dhsonhlLWLKCrrLeHjwJpZaW8htcekpf3Vh51lMl32LR6Xi05VG5O8Iqt01xibl 1TVT/YPgEUDISeScrcSKFBgW2vmuX8AwoEsVs=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+H23iTOI7k8Ml+QrZc6qoSMmFm64ENbOYK4K+fWilks=; b=jTJ6nAudugoI/62HCQBplAbN8A1lU2cw3UAd+QVyBamDzWANXSqZcNA8T+LY0/1bLJ fA22Bue8S7kjsuyOv85XRqHcIA97m/t00LrM/e9O3PAuJh1T0MhCyrOlbcB3VAA3qwr4 CGsHv6Im72+SNSk5/xtBr0L/v+bOKBVkR6m6LP/IJX+rjbj6Ij2wF1U+V0k1Xixr4bF6 xpIAprHJrhTSsNuA1/faSKWofQFWlv8YhnIaFAqgKEqe9kug+0mIT9DDL8YgpdNqC+o6 8+XkvGJeyJXtaxHs9VZp+omUXFsVfaDWnjflSGmeamS6nRFf3nLG+3JFXJAFzF542tSb rwkQ==
X-Gm-Message-State	AA6/9Rmsf1k/+ZfbukfCGSB9iyz/Dp3XvXoEmnkyMRBl0MO+9P7eDM6JSUwtpteu24w4R9CG
X-Received	by 10.66.55.9 with SMTP id n9mr9777651pap.153.1476220360863; Tue, 11 Oct 2016 14:12:40 -0700 (PDT)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, lho@apm.com, Duc Dang <dhdang@apm.com>, Hoan Tran <hotran@apm.com>
X-Original-Date	Tue, 11 Oct 2016 14:12:00 -0700
X-Original-Message-ID	<1476220320-19685-1-git-send-email-hotran@apm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1499213

Show key headers only | View raw

The desired_perf is an abstract performance number. Its value should
be in the range of [lowest perf, highest perf] of CPPC.
The correct calculation is
  desired_perf = freq * cppc_highest_perf / cppc_dmi_max_khz

Signed-off-by: Hoan Tran <hotran@apm.com>
---
 drivers/cpufreq/cppc_cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 1b2f28f..ab1d4b7 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -84,7 +84,7 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
 
 	cpu = all_cpu_data[policy->cpu];
 
-	cpu->perf_ctrls.desired_perf = (u64)target_freq * policy->max / cppc_dmi_max_khz;
+	cpu->perf_ctrls.desired_perf = (u64)target_freq * cpu->perf_caps.highest_perf / cppc_dmi_max_khz;
 	freqs.old = policy->cur;
 	freqs.new = target_freq;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: CPPC: Correct desired_perf calculation Hoan Tran <hotran@apm.com> - 2016-10-11 23:40 +0200
  Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-10-11 23:50 +0200
    Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation Hoan Tran <hotran@apm.com> - 2016-10-12 00:40 +0200
  Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-12 05:30 +0200
  Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation "Prakash, Prashanth" <pprakash@codeaurora.org> - 2016-10-12 17:40 +0200
    Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation Hoan Tran <hotran@apm.com> - 2016-10-12 19:40 +0200

csiph-web