Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499278
| From | Hoan Tran <hotran@apm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation |
| Date | 2016-10-12 00:40 +0200 |
| Message-ID | <srdSh-47Y-1@gated-at.bofh.it> (permalink) |
| References | <srcWd-3tt-9@gated-at.bofh.it> <srd5T-3x4-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Rafael, On Tue, Oct 11, 2016 at 2:50 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, October 11, 2016 02:12:00 PM Hoan Tran wrote: >> The desired_perf is an abstract performance number. Its value should >> be in the range of [lowest perf, highest perf] of CPPC. >> The correct calculation is >> desired_perf = freq * cppc_highest_perf / cppc_dmi_max_khz >> >> Signed-off-by: Hoan Tran <hotran@apm.com> >> --- >> drivers/cpufreq/cppc_cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c >> index 1b2f28f..ab1d4b7 100644 >> --- a/drivers/cpufreq/cppc_cpufreq.c >> +++ b/drivers/cpufreq/cppc_cpufreq.c >> @@ -84,7 +84,7 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy, >> >> cpu = all_cpu_data[policy->cpu]; >> >> - cpu->perf_ctrls.desired_perf = (u64)target_freq * policy->max / cppc_dmi_max_khz; >> + cpu->perf_ctrls.desired_perf = (u64)target_freq * cpu->perf_caps.highest_perf / cppc_dmi_max_khz; >> freqs.old = policy->cur; >> freqs.new = target_freq; >> >> > > This patch has already been applied AFAICS. > You mean this applied patch "cpufreq: CPPC: Avoid overflow when calculating desired_perf" This is another the bug, not the overflow bug. Thanks Hoan > Thanks, > Rafael >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] cpufreq: CPPC: Correct desired_perf calculation Hoan Tran <hotran@apm.com> - 2016-10-11 23:40 +0200
Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-10-11 23:50 +0200
Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation Hoan Tran <hotran@apm.com> - 2016-10-12 00:40 +0200
Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-12 05:30 +0200
Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation "Prakash, Prashanth" <pprakash@codeaurora.org> - 2016-10-12 17:40 +0200
Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation Hoan Tran <hotran@apm.com> - 2016-10-12 19:40 +0200
csiph-web