Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500487
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check |
| Date | 2016-10-13 20:20 +0200 |
| Message-ID | <srSLL-78p-7@gated-at.bofh.it> (permalink) |
| References | <srSLL-78p-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Oct 13, 2016 at 11:09:16AM -0700, Tai Nguyen wrote: > In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(), > which doesn't make sense, as the pointer must be a real, valid pointer. > This doesn't cause a functional problem, as IS_ERR() will evaluate as > false, but the check is bogus and causes static checkers to complain. ... unless the test is actually a misspelled IS_ERR(res) and the current code is broken by effectively skipping it.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] perf: xgene: Remove bogus IS_ERR() check Tai Nguyen <ttnguyen@apm.com> - 2016-10-13 20:20 +0200
Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 20:20 +0200
Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check Mark Rutland <mark.rutland@arm.com> - 2016-10-14 02:50 +0200
csiph-web