Re: [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered)

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered)
Date	2016-10-13 19:20 +0200
Message-ID	<srRPH-6uS-5@gated-at.bofh.it> (permalink)
References	<slGDE-5XZ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/26, Oleg Nesterov wrote:
>
> Hello,
>
> The patches do not depend on each other.

Yes,

> 1/2 is the trivial fix, imo -stable material. The bug is very old it seems,
> but today this race (leading to unbalanced unlock)  manifests itself via
> mysterious BUG_ON's in rcu/sync.c.

Yes. Al, could you take it? Or how else we should route it?

> 2/2 is old, I forgot to send it before. It was already reviewed by Dave and Jan,
> but the generic/068 test from xfstests triggered the warning. This was fixed by
> dbad7c993053 "xfs: stop holding ILOCK over filldir callbacks" so we can hopefully
> kill the early-lockdep-release kludge.

Lets ignore it for now, it does lead to false-positives. Thanks again Jan and Dave
for your help.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered) Oleg Nesterov <oleg@redhat.com> - 2016-09-26 18:10 +0200
  [PATCH 2/2] fs/super.c: don't fool lockdep in freeze_super() and  thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-26 18:10 +0200
    Re: [PATCH 2/2] fs/super.c: don't fool lockdep in freeze_super() and  thaw_super() paths Jan Kara <jack@suse.cz> - 2016-09-26 18:20 +0200
      [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super() and  thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-26 19:00 +0200
        Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Jan Kara <jack@suse.cz> - 2016-09-27 09:00 +0200
          Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-09-27 09:20 +0200
          Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-27 19:30 +0200
            Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-30 19:20 +0200
              Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-02 23:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in         freeze_super() and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-03 18:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-04 19:00 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-04 22:10 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-05 18:40 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-04 21:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-05 18:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Jan Kara <jack@suse.cz> - 2016-10-06 09:30 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-06 19:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-07 00:00 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-07 19:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-08 01:00 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in         freeze_super() and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-09 18:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-10 03:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in         freeze_super() and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-13 19:00 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Johannes Weiner <hannes@cmpxchg.org> - 2016-10-06 15:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in         freeze_super() and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-07 19:00 +0200
  [PATCH 1/2] fs/super.c: fix race between freeze_super() and  thaw_super() Oleg Nesterov <oleg@redhat.com> - 2016-09-26 18:10 +0200
    Re: [PATCH 1/2] fs/super.c: fix race between freeze_super() and  thaw_super() Jan Kara <jack@suse.cz> - 2016-09-26 18:20 +0200
  Re: [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered) Oleg Nesterov <oleg@redhat.com> - 2016-10-13 19:20 +0200

csiph-web