Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super() and thaw_super() paths

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super() and thaw_super() paths
Date	2016-09-30 19:20 +0200
Message-ID	<sn9Dz-4Pc-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <slGDE-5XZ-5@gated-at.bofh.it> <slGNk-64r-13@gated-at.bofh.it> <slHq2-6hN-39@gated-at.bofh.it> <slUwV-6dY-1@gated-at.bofh.it> <sm4mB-3UT-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/27, Oleg Nesterov wrote:
>
> On 09/27, Jan Kara wrote:
> >
> > You can run either:
> >
> > 	./check -g freeze
>
> passed all 6 tests.
>
> > to check just the freezing tests or
> >
> > 	./check
> >
> > to run all sensible tests which is what I'd do (but it will take couple of
> > hours to pass). If that passes, chances are good there are no easy false
> > positives.
>
> It seems that generic/001 just hangs on my laptop. With or without this change.
> Or perhaps I didn't wait enough...

/usr/bin/awk spins in user-mode forever, according to strace it doesn't do
any syscalls. I didn't even try to investigate.

> Or perhaps something is wrong with my very
> limited testing environment. I'll reserve a testing machine tomorrow.

Jan, I gave up.

Whatever I did xfstests-dev/check reports a lot of failures, kernel bugs,
and finally either crashes the kernel or hangs.

With or without this change, and I didn't notice any warning from lockdep.
So I hope we can apply this patch. At least 1/2 which fixes a bug.

Oleg.

Thread

[PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered) Oleg Nesterov <oleg@redhat.com> - 2016-09-26 18:10 +0200
  [PATCH 2/2] fs/super.c: don't fool lockdep in freeze_super() and  thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-26 18:10 +0200
    Re: [PATCH 2/2] fs/super.c: don't fool lockdep in freeze_super() and  thaw_super() paths Jan Kara <jack@suse.cz> - 2016-09-26 18:20 +0200
      [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super() and  thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-26 19:00 +0200
        Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Jan Kara <jack@suse.cz> - 2016-09-27 09:00 +0200
          Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-09-27 09:20 +0200
          Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-27 19:30 +0200
            Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-09-30 19:20 +0200
              Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-02 23:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in         freeze_super() and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-03 18:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-04 19:00 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-04 22:10 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-05 18:40 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-04 21:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-05 18:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Jan Kara <jack@suse.cz> - 2016-10-06 09:30 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-06 19:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-07 00:00 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-07 19:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-08 01:00 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in         freeze_super() and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-09 18:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Dave Chinner <david@fromorbit.com> - 2016-10-10 03:20 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()  and thaw_super() paths Johannes Weiner <hannes@cmpxchg.org> - 2016-10-06 15:50 +0200
                Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in         freeze_super() and thaw_super() paths Oleg Nesterov <oleg@redhat.com> - 2016-10-07 19:00 +0200
  [PATCH 1/2] fs/super.c: fix race between freeze_super() and  thaw_super() Oleg Nesterov <oleg@redhat.com> - 2016-09-26 18:10 +0200
    Re: [PATCH 1/2] fs/super.c: fix race between freeze_super() and  thaw_super() Jan Kara <jack@suse.cz> - 2016-09-26 18:20 +0200

csiph-web